Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip quick info tests #65725

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Unskip quick info tests #65725

merged 3 commits into from
Dec 5, 2022

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Dec 2, 2022 •
edited
Loading

These tests pass now, and moved to the new integration test framework

@dibarbet
Copy link
Member Author

dibarbet commented Dec 2, 2022

all quick info tests pass on 10 iterations - https://dev.azure.com/dnceng-public/public/_build/results?buildId=100481&view=results

@dibarbet dibarbet marked this pull request as ready for review December 2, 2022 21:12
@dibarbet dibarbet requested a review from a team as a code owner December 2, 2022 21:12
@Youssef1313
Copy link
Member

removes the last references to the issue in skipped tests

It seems there are two more

roslyn/src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpUpgradeProject.cs

Line 37 in 4d07c7b

[IdeFact(Skip = "https://github.com/dotnet/roslyn/issues/38301")]

roslyn/src/VisualStudio/IntegrationTest/IntegrationTests/VisualBasic/BasicIntelliSense.cs

Line 35 in 4d07c7b

[WpfFact(Skip = "https://github.com/dotnet/roslyn/issues/38301")]

@dibarbet
Copy link
Member Author

dibarbet commented Dec 2, 2022

It looks like you're right, but I swear I'm not crazy for not finding them
image

Seems like find in files is broken

@dibarbet
Copy link
Member Author

dibarbet commented Dec 2, 2022

I'll look at the remaining instances of 38301 in a followup

@dibarbet dibarbet merged commit dc18d88 into dotnet:main Dec 5, 2022
@dibarbet dibarbet deleted the unskip_quick_info branch December 5, 2022 22:44
@ghost ghost added this to the Next milestone Dec 5, 2022
This was referenced Dec 15, 2022
Closed
Closed
@allisonchou allisonchou mentioned this pull request Dec 15, 2022
Closed
@Cosifne Cosifne modified the milestones: Next, 17.5 P3 Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@sharwell sharwell Awaiting requested review from sharwell

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.5 P3
Development

Successfully merging this pull request may close these issues.
4 participants
@dibarbet @Youssef1313 @CyrusNajmabadi @Cosifne